https://git.drupal.org/project/paragraphs_inline_entity_form.git

Primary tabs

Review of the 8.x-1.x branch (commit b4484c2):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The paragraphs_inline_entity_form_example.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • The paragraphs_inline_entity_form.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/paragraphs_inline_entity_form.dialog.js: line 6, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/paragraphs_inline_entity_form.dialog.js: line 9, col 64, Error - Missing space before function parentheses. (space-before-function-paren)
    
    2 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areview_temp/src/Plugin/EntityBrowser/Widget/ParagraphEntityForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     153 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     167 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 419ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...areviewsh/pareview_temp/css/paragraphs_inline_entity_form.dialog.css
--------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
  2 | WARNING | Line exceeds 80 characters; contains 91 characters
  8 | WARNING | Line exceeds 80 characters; contains 110 characters
 10 | WARNING | Line exceeds 80 characters; contains 102 characters
 16 | WARNING | Line exceeds 80 characters; contains 84 characters
 27 | WARNING | Line exceeds 80 characters; contains 89 characters
 28 | WARNING | Line exceeds 80 characters; contains 105 characters
 30 | WARNING | Line exceeds 80 characters; contains 197 characters
--------------------------------------------------------------------------


FILE: ...ine_entity_form_example/paragraphs_inline_entity_form_example.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  3 | ERROR | [x] Doc comment short description must be on the first line
 11 | ERROR | [ ] paragraphs_inline_entity_form_example_install() is an
    |       |     installation hook and must be declared in an install
    |       |     file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areview_temp/src/Plugin/EntityBrowser/Widget/ParagraphEntityForm.php
--------------------------------------------------------------------------
FOUND 11 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  10 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  10 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
  26 | ERROR   | [x] Array indentation error, expected 6 spaces but found
     |         |     8
  27 | ERROR   | [x] Array indentation error, expected 6 spaces but found
     |         |     8
  28 | ERROR   | [x] Array closing indentation error, expected 4 spaces
     |         |     but found 6
  48 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
  55 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
  55 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  72 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 122 | ERROR   | [x] No space found before comment text; expected "//
     |         |     @todo copy icon for entity embed, see
     |         |     entity_embed_update_8001()" but found "//@todo copy
     |         |     icon for entity embed, see
     |         |     entity_embed_update_8001()"
 150 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 165 | ERROR   | [ ] Type hint "array" missing for $allowed_bundles
 166 | ERROR   | [x] No space found before comment text; expected "//
     |         |     @todo use dependency injection." but found "//@todo
     |         |     use dependency injection."
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/paragraphs_inline_entity_form.module
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  3 | ERROR | [x] Doc comment short description must be on the first line
 11 | ERROR | [ ] paragraphs_inline_entity_form_install() is an
    |       |     installation hook and must be declared in an install
    |       |     file
 26 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
 29 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 864ms; Memory: 4Mb