https://git.drupal.org/project/popup_after_login.git 8.x-1.x

×

Error message

User warning: The following module is missing from the file system: xautoload. For information about how to fix this, see the documentation page. in _drupal_trigger_error_with_delayed_logging() (line 1143 of /var/vhosts/c214000000/site1101/web/public/includes/bootstrap.inc).

Primary tabs

Review of the 8.x-1.x branch (commit feae0df):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • The popup_after_login.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eviewsh/pareview_temp/src/Controller/popupAfterLoginVerification.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     26 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 126ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...vendor/drupal/pareviewsh/pareview_temp/css/popup_after_login_css.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/popup_after_login.module
--------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
  4 | ERROR | [x] Doc comment short description must start with a capital
    |       |     letter
 13 | ERROR | [x] Doc comment short description must start with a capital
    |       |     letter
 18 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
 18 | ERROR | [x] Concat operator must be surrounded by a single space
 19 | ERROR | [x] Expected newline after closing brace
 20 | ERROR | [x] Concat operator must be surrounded by a single space
 25 | ERROR | [x] Doc comment short description must start with a capital
    |       |     letter
 27 | ERROR | [ ] popup_after_login_uninstall() is an installation hook
    |       |     and must be declared in an install file
 29 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/popup_after_login.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...eviewsh/pareview_temp/src/Controller/popupAfterLoginVerification.php
--------------------------------------------------------------------------
FOUND 36 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
 17 | ERROR | [ ] Class name must begin with a capital letter
 22 | ERROR | [x] There should be no white space after an opening "("
 22 | ERROR | [x] Expected 0 spaces between opening bracket and type hint
    |       |     "Request"; 1 found
 22 | ERROR | [x] There should be no white space before a closing ")"
 22 | ERROR | [x] Expected 0 spaces between argument "$request" and
    |       |     closing bracket; 1 found
 24 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
 25 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
 30 | ERROR | [x] Expected 1 space after IF keyword; 0 found
 31 | ERROR | [x] Concat operator must be surrounded by a single space
 34 | ERROR | [x] Space before opening parenthesis of function call
    |       |     prohibited
 34 | ERROR | [x] Concat operator must be surrounded by a single space
 35 | ERROR | [x] There should be no white space after an opening "("
 35 | ERROR | [x] There should be no white space before a closing ")"
 36 | ERROR | [x] Expected newline after closing brace
 36 | ERROR | [x] Use "elseif" in place of "else if"
 36 | ERROR | [x] Concat operator must be surrounded by a single space
 39 | ERROR | [x] Space before opening parenthesis of function call
    |       |     prohibited
 39 | ERROR | [x] Concat operator must be surrounded by a single space
 40 | ERROR | [x] There should be no white space after an opening "("
 40 | ERROR | [x] There should be no white space before a closing ")"
 41 | ERROR | [x] Expected newline after closing brace
 42 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 42 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
 43 | ERROR | [x] There should be no white space after an opening "("
 43 | ERROR | [x] There should be no white space before a closing ")"
 43 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
 43 | ERROR | [x] Whitespace found at end of line
 45 | ERROR | [x] Expected newline after closing brace
 47 | ERROR | [x] There should be no white space after an opening "("
 47 | ERROR | [x] There should be no white space before a closing ")"
 47 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
 47 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...l/pareviewsh/pareview_temp/src/Form/popupAfterLoginConfiguration.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  11 | ERROR   | [ ] Class name must begin with a capital letter
  40 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
  44 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  46 | ERROR   | [x] Whitespace found at end of line
  67 | ERROR   | [x] Whitespace found at end of line
  96 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
  96 | ERROR   | [x] Object operator not indented correctly; expected 6
     |         |     spaces but found 4
  97 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
  98 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
  99 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
 100 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
 101 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 320ms; Memory: 4Mb
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 2, col 2, Error - Expected indentation of 2 spaces but found 1 tab. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 3, col 2, Error - Expected indentation of 2 spaces but found 1 tab. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 4, col 3, Error - Expected indentation of 2 spaces but found 2 tabs. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 5, col 7, Error - Expected indentation of 2 spaces but found 6. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 6, col 2, Error - Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 7, col 2, Error - Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 7, col 22, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 7, col 60, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 8, col 2, Error - Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 8, col 23, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 9, col 11, Error - Expected space(s) after "if". (keyword-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 9, col 11, Error - Expected indentation of 4 spaces but found 10. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 10, col 2, Error - Mixed spaces and tabs. (no-mixed-spaces-and-tabs)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 10, col 32, Error - A space is required after ','. (comma-spacing)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 12, col 9, Error - Expected indentation of 2 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 13, col 7, Error - Expected indentation of 2 spaces but found 6. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 13, col 10, Error - Trailing spaces not allowed. (no-trailing-spaces)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 14, col 5, Error - Expected indentation of 0 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 15, col 3, Error - Expected indentation of 0 spaces but found 2. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/popup_after_login_validation.js: line 16, col 12, Error - Newline required at end of file but not found. (eol-last)

20 problems