Revision of https://git.drupal.org/project/popup_after_login.git from Fri, 06/15/2018 - 16:53

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 4035f34):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/popup_after_login.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     11 | WARNING | Format should be "* Implements hook_foo().", "*
        |         | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
        |         | Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
        |         | "* Implements hook_foo_BAR_ID_bar() for
        |         | xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar()
        |         | for block templates."
    --------------------------------------------------------------------------
    
    Time: 305ms; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eviewsh/pareview_temp/src/Controller/PopupAfterLoginVerification.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     22 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 126ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.