https://git.drupal.org/project/qr_decode.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 0e0f764):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pareviewsh/pareview_temp/src/Plugin/Field/FieldType/QrDecodeItem.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     213 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    Time: 377ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...pareviewsh/pareview_temp/src/Plugin/Field/FieldType/QrDecodeItem.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  45 | ERROR   | [x] Expected 1 blank line before function; 2 found
 121 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
 213 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
 213 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 213 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eview_temp/src/Plugin/Field/FieldFormatter/QrDecodeFormatterType.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 25 | ERROR | [x] Short array syntax must be used to define arrays
 29 | ERROR | [x] Short array syntax must be used to define arrays
 38 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...viewsh/pareview_temp/src/Plugin/Field/FieldWidget/QrDecodeWidget.php
--------------------------------------------------------------------------
FOUND 16 ERRORS AND 3 WARNINGS AFFECTING 13 LINES
--------------------------------------------------------------------------
   8 | WARNING | [x] Unused use statement
   9 | WARNING | [x] Unused use statement
  28 | ERROR   | [x] Expected 1 blank line before function; 2 found
  30 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
  34 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
  49 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
  74 | ERROR   | [ ] Variable "QrDecode" starts with a capital letter,
     |         |     but only $lowerCamelCase or $snake_case is allowed
  74 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "FALSE" but found "false"
  76 | ERROR   | [ ] Variable "QrDecode" starts with a capital letter,
     |         |     but only $lowerCamelCase or $snake_case is allowed
  76 | ERROR   | [x] Comments may not appear after statements
  76 | ERROR   | [x] No space found before comment text; expected "//
     |         |     return decoded text from QR Code" but found
     |         |     "//return decoded text from QR Code"
  76 | ERROR   | [x] Inline comments must start with a capital letter
  76 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 113 | WARNING | [ ] Line exceeds 80 characters; contains 129 characters
 113 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 116 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 3 empty lines
 118 | ERROR   | [ ] More than 2 empty lines are not allowed
 120 | ERROR   | [x] Expected 1 blank line after function; 2 found
 123 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/qr_decode.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 32 | ERROR | [x] Short array syntax must be used to define arrays
 37 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 782ms; Memory: 4Mb