https://git.drupal.org/project/qualtricsxm.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit 2c9761a):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/qualtricsxm_embed/js/iframe_resize.js: line 17, col 5, Error - Unexpected console statement. (no-console)
    
    1 problem
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...drupal/pareviewsh/pareview_temp/src/Controller/DefaultController.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
  6 | WARNING | [x] Unused use statement
 40 | WARNING | [ ] Do not pass empty strings to t()
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...sxm_embed/src/Plugin/Field/FieldFormatter/FieldQualtricsxmIframe.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 44 | WARNING | Do not pass empty strings to t()
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/qualtricsxm.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 110 | ERROR | Concatenating translatable strings is not allowed, use
     |       | placeholders instead and only one string literal
--------------------------------------------------------------------------

Time: 1.03 secs; Memory: 4Mb