Revision of https://git.drupal.org/project/recaptcha_v3.git 8.x-1.x from Fri, 01/10/2020 - 01:09

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 3f471ea):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/recaptcha_v3.js: line 1, col 2, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/recaptcha_v3.js: line 13, col 15, Error - Expected indentation of 12 spaces but found 14. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/recaptcha_v3.js: line 14, col 17, Error - Expected indentation of 14 spaces but found 16. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/recaptcha_v3.js: line 15, col 15, Error - Expected indentation of 12 spaces but found 14. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/recaptcha_v3.js: line 16, col 18, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
    
    5 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/recaptcha_v3.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     89 | WARNING | Variable $captcha_type_module is undefined.
     89 | WARNING | Variable $captcha_type_challenge is undefined.
     91 | WARNING | Variable $captcha_type_module is undefined.
     92 | WARNING | Variable $captcha_type_challenge is undefined.
     99 | WARNING | Variable $captcha_type_challenge is undefined.
    --------------------------------------------------------------------------
    
    Time: 743ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/recaptcha_v3.module
--------------------------------------------------------------------------
FOUND 38 ERRORS AND 2 WARNINGS AFFECTING 31 LINES
--------------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  12 | WARNING | [x] Unused use statement
  36 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  72 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
  74 | ERROR   | [ ] Missing parameter comment
  74 | ERROR   | [ ] Missing parameter type
  75 | ERROR   | [ ] Missing parameter comment
  75 | ERROR   | [ ] Missing parameter type
  76 | ERROR   | [ ] Missing parameter comment
  76 | ERROR   | [ ] Missing parameter type
  78 | ERROR   | [ ] Description for the @return value is missing
 124 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 150 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 152 | ERROR   | [ ] Missing parameter comment
 152 | ERROR   | [ ] Missing parameter type
 153 | ERROR   | [ ] Missing parameter comment
 154 | ERROR   | [ ] Missing parameter comment
 154 | ERROR   | [ ] Missing parameter type
 156 | ERROR   | [ ] Description for the @return value is missing
 163 | ERROR   | [x] Expected 1 blank line after function; 2 found
 181 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
 182 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
 183 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
 184 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
 185 | ERROR   | [x] Array closing indentation error, expected 2 spaces
     |         |     but found 4
 190 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
 202 | ERROR   | [x] Expected newline after closing brace
 221 | ERROR   | [ ] Missing parameter comment
 222 | ERROR   | [ ] Missing parameter comment
 224 | ERROR   | [ ] Description for the @return value is missing
 236 | ERROR   | [ ] Missing parameter comment
 237 | ERROR   | [ ] Missing parameter comment
 237 | ERROR   | [ ] Missing parameter type
 239 | ERROR   | [ ] Description for the @return value is missing
 258 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 258 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 259 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 259 | ERROR   | [ ] Missing parameter comment
 259 | ERROR   | [ ] Missing parameter type
 261 | ERROR   | [ ] Description for the @return value is missing
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  9 | WARNING | Line exceeds 80 characters; contains 116 characters
 12 | WARNING | Line exceeds 80 characters; contains 120 characters
 16 | WARNING | Line exceeds 80 characters; contains 121 characters
 29 | WARNING | Line exceeds 80 characters; contains 100 characters
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/config/install/recaptcha_v3.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/ReCaptchaV3ActionListBuilder.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 39 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/ReCaptchaV3ActionInterface.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] Doc comment short description must end with a full stop
 19 | ERROR | [ ] Missing parameter comment
 26 | ERROR | [ ] Description for the @return value is missing
 33 | ERROR | [ ] Missing parameter comment
 40 | ERROR | [ ] Description for the @return value is missing
 47 | ERROR | [ ] Missing parameter comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Form/ReCaptchaV3SettingsForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
  18 | ERROR   | Missing short description in doc comment
  23 | ERROR   | Missing short description in doc comment
  38 | ERROR   | Missing parameter comment
  39 | ERROR   | Missing parameter comment
  40 | ERROR   | Missing parameter comment
  41 | ERROR   | Missing parameter comment
 141 | WARNING | Line exceeds 80 characters; contains 87 characters
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/ReCaptchaV3ActionForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement
 24 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 26 | ERROR   | [ ] Missing parameter comment
 27 | ERROR   | [x] There must be no blank lines after the function
    |         |     comment
 45 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 74 | ERROR   | [ ] Inline doc block comments are not allowed; use "/*
    |         |     Comment */" or "// Comment" instead
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...al/pareviewsh/pareview_temp/src/Form/ReCaptchaV3ActionDeleteForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 16 | WARNING | Possible useless method overriding detected
 17 | ERROR   | Inline doc block comments are not allowed; use "/*
    |         | Comment */" or "// Comment" instead
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/recaptcha_v3.links.action.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/recaptcha_v3.libraries.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 19 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.29 secs; Memory: 6Mb