Revision of https://git.drupal.org/project/rest_api_access_token.git from Tue, 06/18/2019 - 02:05

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 3790324):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...viewsh/pareview_temp/src/EventSubscriber/CacheEndpointSubscriber.php
    --------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      94 | ERROR | [x] Object operator not indented correctly; expected 6
         |       |     spaces but found 8
     120 | ERROR | [x] Object operator not indented correctly; expected 6
         |       |     spaces but found 8
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 2.2 secs; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...sh/pareview_temp/src/Authentication/Provider/AccessTokenProvider.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     103 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/Controller/AuthController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     137 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/rest_api_access_token.routing.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      7 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
     16 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
     26 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
    --------------------------------------------------------------------------
    
    Time: 1.06 secs; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.