Revision of https://git.drupal.org/project/rest_api_access_token.git from Thu, 06/20/2019 - 01:59

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit e767070):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/rest_api_access_token.routing.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      7 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
     16 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
     26 | WARNING | Open page callback found, please add a comment before the
        |         | line why there is no access restriction
    --------------------------------------------------------------------------
    
    Time: 916ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...sh/pareview_temp/src/Authentication/Provider/AccessTokenProvider.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 13 | WARNING | [x] Unused use statement
 14 | WARNING | [x] Unused use statement
 48 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 48 | ERROR   | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Controller/AuthController.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 48 | ERROR | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.62 secs; Memory: 4Mb