https://git.drupal.org/project/sfweb2lead_webform.git 8.x-5.x

Primary tabs

Git errors: Review of the 8.x-5.x branch (commit 8d69b49):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The sfweb2lead_webform.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/sfweb2lead_webform.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: .../src/Plugin/WebformHandler/SalesforceWebToLeadPostWebformHandler.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     36 | WARNING | Unused variable $field_names.
    --------------------------------------------------------------------------
    
    Time: 316ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/sfweb2lead_webform.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: .../src/Plugin/WebformHandler/SalesforceWebToLeadPostWebformHandler.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 25 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
 28 | ERROR | The @var tag must be the first tag in a member variable
    |       | comment
 30 | ERROR | If the line declaring an array spans longer than 80
    |       | characters, each element should be broken into its own line
--------------------------------------------------------------------------

Time: 596ms; Memory: 4Mb