Revision of https://git.drupal.org/project/sharedemail.git 7.x-1.x from Fri, 03/15/2019 - 01:06

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit eb35dab):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove all old CVS $Id tags, they are not needed anymore.
    sharedemail.info:1:; $Id:$
    sharedemail.install:2:// $Id:$
    sharedemail.module:2:// $Id:$
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/sharedemail.install
    --------------------------------------------------------------------------
    FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      2 | WARNING | There must be no blank line following an inline comment
     12 | ERROR   | Do not use t() or st() in installation phase hooks, use
        |         | $t = get_t() to retrieve the appropriate localization
        |         | function name
     18 | WARNING | Do not use UPDATE queries with db_query(), use
        |         | db_update() instead
     20 | ERROR   | Do not use t() or st() in installation phase hooks, use
        |         | $t = get_t() to retrieve the appropriate localization
        |         | function name
    --------------------------------------------------------------------------
    
    
    FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/sharedemail.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      2 | WARNING | There must be no blank line following an inline comment
     59 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    Time: 260ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/sharedemail.install
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
  2 | ERROR   | [x] You must use "/**" style comments for a file comment
  2 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
  5 | ERROR   | [x] Doc comment short description must be on the first
    |         |     line
  9 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
  9 | ERROR   | [x] Function comment short description must start with
    |         |     exactly one space
 12 | WARNING | [ ] Translatable strings must not begin or end with white
    |         |     spaces, use placeholders with t() for variables
 12 | ERROR   | [ ] Concatenating translatable strings is not allowed,
    |         |     use placeholders instead and only one string literal
 12 | ERROR   | [x] Concat operator must be surrounded by a single space
 13 | ERROR   | [x] Concat operator must be surrounded by a single space
 14 | ERROR   | [x] Concat operator must be surrounded by a single space
 24 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 11 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 14 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
 19 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/sharedemail.module
--------------------------------------------------------------------------
FOUND 31 ERRORS AND 10 WARNINGS AFFECTING 30 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   2 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
   2 | ERROR   | [x] You must use "/**" style comments for a file comment
   2 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  10 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  15 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     4
  15 | ERROR   | [x] Concat operator must be surrounded by a single space
  15 | ERROR   | [x] Concat operator must be surrounded by a single space
  16 | ERROR   | [x] Case breaking statement indented incorrectly;
     |         |     expected 6 spaces, found 4
  21 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  35 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  47 | ERROR   | [x] Whitespace found at end of line
  49 | ERROR   | [x] Expected 1 blank line after function; 2 found
  53 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  59 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
  59 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     0
  59 | ERROR   | [x] 2 spaces found before inline comment; expected "//
     |         |     $form = array();" but found "//  $form = array();"
  61 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  61 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
  61 | ERROR   | [x] Concat operator must be surrounded by a single space
  62 | ERROR   | [x] Concat operator must be surrounded by a single space
  63 | ERROR   | [x] Concat operator must be surrounded by a single space
  78 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  88 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  98 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
 107 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 110 | ERROR   | [x] There should be no white space after an opening "("
 110 | ERROR   | [x] There should be no white space before a closing ")"
 111 | ERROR   | [x] There should be no white space after an opening "("
 111 | ERROR   | [x] There should be no white space before a closing ")"
 131 | ERROR   | [x] Concat operator must be surrounded by a single space
 150 | ERROR   | [ ] Missing parameter type
 151 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 152 | ERROR   | [ ] Missing parameter type
 153 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 154 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 154 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 155 | ERROR   | [x] Return comment indentation must be 3 spaces, found 2
     |         |     spaces
 156 | ERROR   | [x] Return comment indentation must be 3 spaces, found 2
     |         |     spaces
 180 | ERROR   | [x] Inline comments must start with a capital letter
 185 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/tests/sharedemail.test
--------------------------------------------------------------------------
FOUND 100 ERRORS AFFECTING 53 LINES
--------------------------------------------------------------------------
   1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
     |       |     line
   2 | ERROR | [x] Missing class doc comment
   2 | ERROR | [ ] Class name must begin with a capital letter
   4 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
   4 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
   4 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
   5 | ERROR | [x] There must be no blank lines after the function
     |       |     comment
   7 | ERROR | [x] Visibility must be declared on method "get_info"
   7 | ERROR | [ ] Method name "sharedemailTest::get_info" is not in
     |       |     lowerCamel format
  16 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  16 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  20 | ERROR | [x] Whitespace found at end of line
  21 | ERROR | [x] Missing function doc comment
  25 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  25 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  25 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  27 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_user" is not in
     |       |     lowerCamel format
  29 | ERROR | [x] Inline comments must start with a capital letter
  29 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  33 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  33 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  33 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  35 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_menu" is not in
     |       |     lowerCamel format
  37 | ERROR | [x] Inline comments must start with a capital letter
  37 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  41 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  41 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  41 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  43 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_admin_settings" is
     |       |     not in lowerCamel format
  45 | ERROR | [x] Inline comments must start with a capital letter
  45 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  49 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  49 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  49 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  51 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_perm" is not in
     |       |     lowerCamel format
  53 | ERROR | [x] Inline comments must start with a capital letter
  53 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  57 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  57 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  57 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  59 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_access" is not in
     |       |     lowerCamel format
  61 | ERROR | [x] Inline comments must start with a capital letter
  61 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  65 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  65 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  65 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  67 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_node_info" is not
     |       |     in lowerCamel format
  69 | ERROR | [x] Inline comments must start with a capital letter
  69 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  73 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  73 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  73 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  75 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_form" is not in
     |       |     lowerCamel format
  77 | ERROR | [x] Inline comments must start with a capital letter
  77 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  81 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  81 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  81 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  83 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_insert" is not in
     |       |     lowerCamel format
  85 | ERROR | [x] Inline comments must start with a capital letter
  85 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  89 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  89 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  89 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  91 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_update" is not in
     |       |     lowerCamel format
  93 | ERROR | [x] Inline comments must start with a capital letter
  93 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
  97 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
  97 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
  97 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  99 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_delete" is not in
     |       |     lowerCamel format
 101 | ERROR | [x] Inline comments must start with a capital letter
 101 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 105 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
 105 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
 105 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 107 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_load" is not in
     |       |     lowerCamel format
 109 | ERROR | [x] Inline comments must start with a capital letter
 109 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 113 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
 113 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
 113 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 115 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_view" is not in
     |       |     lowerCamel format
 117 | ERROR | [x] Inline comments must start with a capital letter
 117 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 121 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
 121 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
 121 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 123 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_block" is not in
     |       |     lowerCamel format
 125 | ERROR | [x] Inline comments must start with a capital letter
 125 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 129 | ERROR | [x] Function comment short description must start with
     |       |     exactly one space
 129 | ERROR | [x] Doc comment short description must start with a
     |       |     capital letter
 129 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
 131 | ERROR | [ ] Public method name
     |       |     "sharedemailTest::test_sharedemail_simpletest" is not
     |       |     in lowerCamel format
 133 | ERROR | [x] Inline comments must start with a capital letter
 133 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 134 | ERROR | [x] Expected 1 blank line after function; 0 found
 135 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
 136 | ERROR | [x] A closing tag is not permitted at the end of a PHP
     |       |     file
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 84 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/sharedemail.info
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 685ms; Memory: 4Mb