https://git.drupal.org/project/sieroty 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit afe92c9):
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./README.md:                           ASCII text, with CRLF line terminators
    ./src/Plugin/Filter/SierotyFilter.php: PHP script, ASCII text, with CRLF line terminators
    README.md
    src/Plugin/Filter/SierotyFilter.php
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Plugin/Filter/SierotyFilter.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but
       |       |     found "\r\n"
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 393ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.