https://git.drupal.org/project/signaturefield.git

Primary tabs

Git errors: Review of the 7.x-2.x branch (commit 601d507):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
  • The signaturefield.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • ./includes/webform.inc: All functions should be prefixed with your module/theme name (signaturefield) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function _webform_edit_signaturefield($component) {
    function _webform_render_signaturefield($component, $value = NULL) {
    function _webform_display_signaturefield($component, $value, $format = 'html') {
    
  • ./includes/system.inc: All functions should be prefixed with your module/theme name (signaturefield) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function form_type_signaturefield_value($element, $edit = FALSE, $form_state) {
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 2, col 2, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 3, col 29, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 4, col 5, Error - Expected space or tab after '//' in comment. (spaced-comment)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 5, col 33, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 5, col 35, Error - Missing space before opening brace. (space-before-blocks)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 7, col 7, Error - Expected space or tab after '//' in comment. (spaced-comment)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 8, col 18, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 8, col 26, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 8, col 28, Error - Missing space before opening brace. (space-before-blocks)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.js: line 8, col 79, Error - Missing semicolon. (semi)
    
    10 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/system.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     79 | WARNING | Unused variable $key.
    --------------------------------------------------------------------------
    
    
    FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/field.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      42 | WARNING | Unused variable $delta.
      45 | WARNING | Variable $error_element is undefined.
      99 | WARNING | There must be no blank line following an inline comment
     204 | WARNING | Unused variable $value.
    --------------------------------------------------------------------------
    
    Time: 651ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
  4 | WARNING | Line exceeds 80 characters; contains 86 characters
 17 | WARNING | Line exceeds 80 characters; contains 116 characters
 20 | WARNING | Line exceeds 80 characters; contains 117 characters
 59 | WARNING | Line exceeds 80 characters; contains 115 characters
 76 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.module
--------------------------------------------------------------------------
FOUND 25 ERRORS AND 1 WARNING AFFECTING 19 LINES
--------------------------------------------------------------------------
   9 | ERROR   | [x] Doc comment short description must start with a
     |         |     capital letter
  18 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  69 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
  69 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  69 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
  71 | ERROR   | [ ] Missing parameter comment
  72 | ERROR   | [ ] Missing parameter comment
  73 | ERROR   | [ ] Missing parameter comment
  74 | ERROR   | [ ] Missing parameter comment
  75 | ERROR   | [ ] Missing parameter comment
  76 | ERROR   | [ ] Missing parameter comment
  76 | ERROR   | [ ] Doc comment for parameter $colour does not match
     |         |     actual variable name $thickness
  77 | ERROR   | [ ] Missing parameter comment
  79 | ERROR   | [ ] If there is no return value for a function, there
     |         |     must not be a @return tag.
  79 | ERROR   | [ ] Description for the @return value is missing
 101 | ERROR   | [x] Function comment short description must start with
     |         |     exactly one space
 103 | ERROR   | [x] Expected 1 space after asterisk; 2 found
 103 | ERROR   | [ ] Missing parameter type
 104 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 4 spaces
 106 | ERROR   | [x] Expected 1 space after asterisk; 2 found
 106 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 106 | ERROR   | [ ] Return type missing for @return tag in function
     |         |     comment
 107 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4
     |         |     spaces
 114 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 120 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 130 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 33 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.info
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  6 | ERROR | It's only necessary to declare files[] if they declare a
    |       | class or interface.
  7 | ERROR | Declared file was not found
  8 | ERROR | Declared file was not found
  9 | ERROR | Declared file was not found
 10 | ERROR | Declared file was not found
 11 | ERROR | It's only necessary to declare files[] if they declare a
    |       | class or interface.
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/webform.inc
--------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------
  44 | ERROR | [ ] Missing parameter type
  47 | ERROR | [ ] Return type missing for @return tag in function
     |       |     comment
  89 | ERROR | [ ] Missing parameter type
  91 | ERROR | [ ] Missing parameter type
 125 | ERROR | [ ] Missing parameter type
 127 | ERROR | [ ] Missing parameter type
 130 | ERROR | [ ] Missing parameter type
 135 | ERROR | [ ] Return type missing for @return tag in function
     |       |     comment
 151 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 152 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 157 | ERROR | [x] Array closing indentation error, expected 4 spaces but
     |       |     found 6
 164 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/system.inc
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 9 LINES
--------------------------------------------------------------------------
  15 | ERROR   | [x] 4 spaces found before inline comment; expected "//
     |         |     'arguments' => array('element' => NULL)," but found
     |         |     "//    'arguments' => array('element' => NULL),"
  15 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  57 | ERROR   | [x] Missing function doc comment
  57 | ERROR   | [ ] Arguments with default values must be at the end of
     |         |     the argument list
  60 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  72 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
  86 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
  94 | ERROR   | [x] Array closing indentation error, expected 2 spaces
     |         |     but found 4
 101 | ERROR   | [ ] Missing short description in doc comment
 113 | ERROR   | [ ] Missing short description in doc comment
 120 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/help.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/includes/field.inc
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------
  54 | ERROR   | [x] Doc comment long description must start with a
     |         |     capital letter
  99 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 106 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 14
 107 | ERROR   | [x] Array indentation error, expected 12 spaces but
     |         |     found 14
 108 | ERROR   | [x] Array closing indentation error, expected 10 spaces
     |         |     but found 12
 187 | ERROR   | [x] Doc comment long description must start with a
     |         |     capital letter
 224 | ERROR   | [x] Doc comment long description must start with a
     |         |     capital letter
 237 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/templates/signaturefield.tpl.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  5 | ERROR | [x] Doc comment short description must end with a full stop
 13 | ERROR | [x] There should be no white space after an opening "{"
 13 | ERROR | [x] There should be no white space before a closing "}"
 13 | ERROR | [x] Closing brace must be on a line by itself
 16 | ERROR | [x] There should be no white space after an opening "{"
 16 | ERROR | [x] There should be no white space before a closing "}"
 16 | ERROR | [x] Expected 1 newline at end of file; 2 found
 16 | ERROR | [x] Closing brace must be on a line by itself
 16 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/signaturefield.css
--------------------------------------------------------------------------
FOUND 70 ERRORS AFFECTING 53 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
  9 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
  9 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 10 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 10 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 14 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 14 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 15 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 15 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 16 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 17 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 18 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 22 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 26 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 30 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 31 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 32 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 33 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 34 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 35 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 71 | ERROR | [x] Expected 1 space before opening brace of class
    |       |     definition; 0 found
 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 76 | ERROR | [x] Spaces must be used to indent lines; tabs are not
    |       |     allowed
 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 70 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.23 secs; Memory: 6Mb