https://git.drupal.org/project/simply_signups.git

Primary tabs

Review of the 8.x-2.x branch (commit 310b7a1):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pareviewsh/pareview_temp/src/Form/SimplySignupsNodesSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
    --------------------------------------------------------------------------
     102 | WARNING | Unused variable $updated.
     139 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     203 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     211 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     238 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     257 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     278 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     313 | WARNING | Unused variable $absolute.
     315 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...l/pareviewsh/pareview_temp/src/Form/SimplySignupsNodesSingleForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
    --------------------------------------------------------------------------
     62 | WARNING | Variable $node_storage is undefined.
     62 | WARNING | Unused variable $node.
    --------------------------------------------------------------------------
    
    
    FILE: ...reviewsh/pareview_temp/src/Form/SimplySignupsTemplatesFieldsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      30 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     166 | WARNING | Unused variable $values.
     175 | WARNING | Unused variable $tid.
     176 | WARNING | Unused variable $count.
     190 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../pareviewsh/pareview_temp/src/Form/SimplySignupsTemplatesAddForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     88 | WARNING | Unused variable $tid.
    --------------------------------------------------------------------------
    
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/SimplySignupsListForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 15 WARNINGS AFFECTING 15 LINES
    --------------------------------------------------------------------------
      28 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      32 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
      39 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      45 | WARNING | Unused variable $attendedCount.
      46 | WARNING | Unused variable $statusCount.
      49 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      50 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      51 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      52 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      53 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      77 | WARNING | format_date() calls should be avoided in classes, use
         |         | dependency injection and the "date.formatter" service
         |         | instead
      94 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      96 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     130 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     169 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/SimplySignupsNodesApplyTemplateForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      61 | WARNING | Unused variable $nid.
      63 | WARNING | Variable $id is undefined.
     136 | WARNING | Unused variable $nid.
    --------------------------------------------------------------------------
    
    
    FILE: ...reviewsh/pareview_temp/src/Form/SimplySignupsNodesSingleEditForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
      25 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      30 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      69 | WARNING | Unused variable $type.
     115 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     145 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     150 | WARNING | Unused variable $query.
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/SimplySignupsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 28 WARNINGS AFFECTING 26 LINES
    --------------------------------------------------------------------------
      32 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      62 | WARNING | Unused variable $type.
      97 | WARNING | Unused variable $node.
      98 | WARNING | Variable $id is undefined.
      99 | WARNING | Variable $nid is undefined.
     102 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     112 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     113 | WARNING | Unused variable $title.
     114 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     115 | WARNING | format_date() calls should be avoided in classes, use
         |         | dependency injection and the "date.formatter" service
         |         | instead
     118 | WARNING | Unused variable $nodeLink.
     151 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     151 | WARNING | Unused variable $config.
     152 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     157 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     159 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     162 | WARNING | Unused variable $startDate.
     163 | WARNING | Unused variable $endDate.
     165 | WARNING | Unused variable $absolute.
     166 | WARNING | Unused variable $maxSignups.
     167 | WARNING | Unused variable $status.
     171 | WARNING | format_date() calls should be avoided in classes, use
         |         | dependency injection and the "date.formatter" service
         |         | instead
     177 | WARNING | Unused variable $created.
     178 | WARNING | Unused variable $updated.
     195 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     210 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
     210 | WARNING | Unused variable $type.
     230 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
    --------------------------------------------------------------------------
    
    
    FILE: ...pareviewsh/pareview_temp/src/Form/SimplySignupsTemplatesEditForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     123 | WARNING | Unused variable $tid.
     132 | WARNING | Unused variable $count.
    --------------------------------------------------------------------------
    
    
    FILE: ...h/pareview_temp/src/Form/Field/SimplySignupsFieldsCheckboxesForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
    --------------------------------------------------------------------------
      27 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      44 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      79 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     132 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     148 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     153 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     207 | WARNING | Unused variable $tid.
     221 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     232 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsSelectForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES
    --------------------------------------------------------------------------
      27 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      44 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      79 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     132 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     148 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     153 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     168 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     173 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     214 | WARNING | Unused variable $tid.
     228 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     240 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...sh/pareview_temp/src/Form/Field/SimplySignupsFieldsTextfieldForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     152 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     174 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     215 | WARNING | Unused variable $tid.
     229 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     239 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsNumberForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 21 WARNINGS AFFECTING 21 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     152 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     159 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     163 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     169 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     171 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     176 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     178 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     183 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     184 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     189 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     190 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     227 | WARNING | Unused variable $tid.
     241 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     253 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsRadiosForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
    --------------------------------------------------------------------------
      27 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      44 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      79 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     132 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     148 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     153 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     207 | WARNING | Unused variable $tid.
     221 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     232 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...wsh/pareview_temp/src/Form/Field/SimplySignupsFieldsTextareaForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     152 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     206 | WARNING | Unused variable $tid.
     220 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     229 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...viewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsRadioForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     153 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     190 | WARNING | Unused variable $tid.
     204 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     211 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsHiddenForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     135 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     150 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     192 | WARNING | Unused variable $tid.
     206 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     214 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...reviewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsTelForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     152 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     166 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     207 | WARNING | Unused variable $tid.
     221 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     230 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...viewsh/pareview_temp/src/Form/Field/SimplySignupsFieldsEmailForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     147 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     152 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     162 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     199 | WARNING | Unused variable $tid.
     213 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     221 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...wsh/pareview_temp/src/Form/Field/SimplySignupsFieldsCheckboxForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
    --------------------------------------------------------------------------
      26 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      43 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      78 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     131 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     146 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     153 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     193 | WARNING | Unused variable $tid.
     207 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     214 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...areviewsh/pareview_temp/src/Form/SimplySignupsNodesFieldsAddForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
    --------------------------------------------------------------------------
     26 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     30 | WARNING | Node::load calls should be avoided in classes, use
        |         | dependency injection instead
     46 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     48 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     49 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     50 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     51 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     52 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     53 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     54 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     55 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     56 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     57 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     58 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     60 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     67 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...iewsh/pareview_temp/src/Form/SimplySignupsTemplatesFieldsAddForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
    --------------------------------------------------------------------------
     25 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     29 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     47 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     49 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     50 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     51 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     52 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     53 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     54 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     55 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     56 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     57 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     58 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     59 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     61 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     68 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...l/pareviewsh/pareview_temp/src/Form/SimplySignupsNodesFieldsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 8 LINES
    --------------------------------------------------------------------------
      28 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      32 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
      40 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
      40 | WARNING | Unused variable $type.
      77 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     210 | WARNING | Unused variable $values.
     227 | WARNING | Unused variable $nid.
     228 | WARNING | Unused variable $count.
     242 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/simply_signups.install
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      21 | WARNING | Unused variable $mail.
     689 | WARNING | Unused variable $connection.
    --------------------------------------------------------------------------
    
    Time: 8.3 secs; Memory: 14Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
 13 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 14 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 38 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 42 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 43 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
 48 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/assets/css/simply-signups.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 74 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/simply_signups.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 360 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/simply_signups.module
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
   5 | WARNING | [x] Unused use statement
   6 | WARNING | [x] Unused use statement
  15 | ERROR   | [x] Missing function doc comment
  34 | ERROR   | [x] Missing function doc comment
  74 | ERROR   | [x] PHP keywords must be lowercase; expected "and" but
     |         |     found "AND"
  89 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 101 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 111 | ERROR   | [x] PHP keywords must be lowercase; expected "and" but
     |         |     found "AND"
 114 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 145 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/simply_signups.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  1 | WARNING | [ ] Remove "version" from the info file, it will be added
    |         |     by drupal.org packaging automatically
 13 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Utility/SimplySignupsUtility.php
--------------------------------------------------------------------------
FOUND 61 ERRORS AFFECTING 29 LINES
--------------------------------------------------------------------------
   7 | ERROR | [x] Missing class doc comment
   8 | ERROR | [x] Missing function doc comment
   8 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::sanitize_options" is not in
     |       |     lowerCamel format
   8 | ERROR | [x] Expected 1 blank line before function; 0 found
  10 | ERROR | [x] Short array syntax must be used to define arrays
  11 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
  28 | ERROR | [x] Missing function doc comment
  28 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::sanitize_options_select" is not
     |       |     in lowerCamel format
  30 | ERROR | [x] Short array syntax must be used to define arrays
  37 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
  54 | ERROR | [x] Missing function doc comment
  54 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::sanitize_options_textarea" is
     |       |     not in lowerCamel format
  58 | ERROR | [x] PHP keywords must be lowercase; expected "and" but
     |       |     found "AND"
  59 | ERROR | [x] Concat operator must be surrounded by a single space
  59 | ERROR | [x] Concat operator must be surrounded by a single space
  59 | ERROR | [x] Concat operator must be surrounded by a single space
  69 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
  69 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_number_of_attending" is not
     |       |     in lowerCamel format
  69 | ERROR | [x] Expected 1 blank line before function; 0 found
  80 | ERROR | [x] Expected 1 space before "+"; 0 found
  80 | ERROR | [x] Expected 1 space after "+"; 0 found
  92 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
  92 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_number_of_signups" is not
     |       |     in lowerCamel format
  92 | ERROR | [x] Expected 1 blank line before function; 0 found
 109 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
 109 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_number_of_checkins" is not
     |       |     in lowerCamel format
 109 | ERROR | [x] Expected 1 blank line before function; 0 found
 127 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
 127 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_number_of_checkedins_attending"
     |       |     is not in lowerCamel format
 127 | ERROR | [x] Expected 1 blank line before function; 0 found
 148 | ERROR | [x] Whitespace found at end of line
 152 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
 152 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_number_of_fields" is not in
     |       |     lowerCamel format
 152 | ERROR | [x] Expected 1 blank line before function; 0 found
 164 | ERROR | [x] Missing function doc comment
 164 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_start_date" is not in
     |       |     lowerCamel format
 182 | ERROR | [x] Missing function doc comment
 182 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_end_date" is not in
     |       |     lowerCamel format
 200 | ERROR | [x] Missing function doc comment
 200 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::get_max_attending" is not in
     |       |     lowerCamel format
 218 | ERROR | [x] Missing function doc comment
 218 | ERROR | [ ] Public method name
     |       |     "SimplySignupsUtility::format_telephone" is not in
     |       |     lowerCamel format
 220 | ERROR | [x] Expected one space after the comma, 0 found
 223 | ERROR | [x] A cast statement must be followed by a single space
 224 | ERROR | [x] Short array syntax must be used to define arrays
 229 | ERROR | [x] Concat operator must be surrounded by a single space
 229 | ERROR | [x] Concat operator must be surrounded by a single space
 229 | ERROR | [x] Concat operator must be surrounded by a single space
 229 | ERROR | [x] Concat operator must be surrounded by a single space
 229 | ERROR | [x] Concat operator must be surrounded by a single space
 232 | ERROR | [x] Concat operator must be surrounded by a single space
 232 | ERROR | [x] Concat operator must be surrounded by a single space
 232 | ERROR | [x] Concat operator must be surrounded by a single space
 232 | ERROR | [x] Concat operator must be surrounded by a single space
 232 | ERROR | [x] Concat operator must be surrounded by a single space
 235 | ERROR | [x] Concat operator must be surrounded by a single space
 235 | ERROR | [x] Concat operator must be surrounded by a single space
 235 | ERROR | [x] Concat operator must be surrounded by a single space
 235 | ERROR | [x] Concat operator must be surrounded by a single space
 240 | ERROR | [x] Expected 1 blank line after function; 0 found
 241 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 49 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Access/SimplySignupsAccess.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
  9 | WARNING | [x] Unused use statement
 22 | ERROR   | [ ] Type hint "\Drupal\node\NodeInterface" missing for
    |         |     $node
 32 | ERROR   | [x] PHP keywords must be lowercase; expected "and" but
    |         |     found "AND"
 38 | ERROR   | [x] Missing function doc comment
 48 | ERROR   | [x] PHP keywords must be lowercase; expected "and" but
    |         |     found "AND"
 53 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 53 | ERROR   | [x] The closing brace for the class must have an empty
    |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../pareviewsh/pareview_temp/src/Controller/SimplySignupsController.php
--------------------------------------------------------------------------
FOUND 55 ERRORS AND 11 WARNINGS AFFECTING 34 LINES
--------------------------------------------------------------------------
   7 | WARNING | [x] Unused use statement
   8 | WARNING | [x] Unused use statement
   9 | WARNING | [x] Unused use statement
  11 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  16 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  29 | ERROR   | [x] Missing class doc comment
  73 | ERROR   | [ ] Description for the @return value is missing
 126 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 178 | WARNING | [ ] Avoid backslash escaping in translatable strings
     |         |     when possible, use "" quotes instead
 189 | ERROR   | [x] Missing function doc comment
 240 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 292 | WARNING | [ ] Avoid backslash escaping in translatable strings
     |         |     when possible, use "" quotes instead
 303 | ERROR   | [x] Missing function doc comment
 310 | ERROR   | [x] Whitespace found at end of line
 316 | ERROR   | [x] Whitespace found at end of line
 338 | ERROR   | [x] Concat operator must be surrounded by a single space
 338 | ERROR   | [x] Concat operator must be surrounded by a single space
 340 | ERROR   | [x] Expected 1 blank line after function; 0 found
 341 | ERROR   | [x] Missing function doc comment
 366 | ERROR   | [x] Concat operator must be surrounded by a single space
 366 | ERROR   | [x] Concat operator must be surrounded by a single space
 368 | ERROR   | [x] Expected 1 blank line after function; 0 found
 369 | ERROR   | [x] Missing function doc comment
 397 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 397 | ERROR   | [x] Concat operator must be surrounded by a single space
 397 | ERROR   | [x] Concat operator must be surrounded by a single space
 397 | ERROR   | [x] Concat operator must be surrounded by a single space
 420 | ERROR   | [x] Concat operator must be surrounded by a single space
 421 | ERROR   | [x] Concat operator must be surrounded by a single space
 422 | ERROR   | [x] Concat operator must be surrounded by a single space
 423 | ERROR   | [x] Concat operator must be surrounded by a single space
 436 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 436 | ERROR   | [x] Concat operator must be surrounded by a single space
 441 | ERROR   | [x] Concat operator must be surrounded by a single space
 441 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 454 | ERROR   | [x] Concat operator must be surrounded by a single space
 458 | ERROR   | [x] Concat operator must be surrounded by a single space
 458 | ERROR   | [x] Concat operator must be surrounded by a single space
 459 | ERROR   | [x] Concat operator must be surrounded by a single space
 471 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 471 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 59 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/src/Form/Config/SimplySignupsTemplatesConfigForm.php
--------------------------------------------------------------------------
FOUND 11 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------
  10 | WARNING | [x] Unused use statement
  21 | ERROR   | [x] Missing function doc comment
  26 | ERROR   | [x] Missing function doc comment
  40 | ERROR   | [x] Missing function doc comment
  44 | ERROR   | [x] Expected 1 blank line after function; 2 found
  46 | ERROR   | [x] Whitespace found at end of line
  61 | ERROR   | [x] Short array syntax must be used to define arrays
  65 | ERROR   | [x] Short array syntax must be used to define arrays
  69 | ERROR   | [x] Short array syntax must be used to define arrays
  73 | ERROR   | [x] Short array syntax must be used to define arrays
  76 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
 169 | ERROR   | [x] Expected 1 newline at end of file; 0 found
 169 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Form/Config/SimplySignupsConfigForm.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
 17 | ERROR | [x] Missing function doc comment
 21 | ERROR | [x] Missing function doc comment
 25 | ERROR | [x] Expected 1 blank line after function; 0 found
 33 | ERROR | [x] Missing function doc comment
 98 | ERROR | [x] Expected 1 newline at end of file; 0 found
 98 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Form/SimplySignupsListForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 66 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: '{"width":"100%"}'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 12.49 secs; Memory: 16Mb