https://git.drupal.org/project/smtp.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 10a6483):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...r/drupal/pareviewsh/pareview_temp/src/Plugin/Mail/SMTPMailSystem.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     252 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Form/SMTPConfigForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     259 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     263 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     336 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     346 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...ewsh/pareview_temp/tests/src/Unit/Plugin/Mail/SMTPMailSystemTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     34 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    Time: 1.34 secs; Memory: 20Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/smtp.permissions.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/smtp.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 19 | ERROR | [x] Space found before object operator
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/Tests/SmtpTest.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
  8 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 15 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 22 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 24 | WARNING | [ ] Possible useless method overriding detected
 29 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 34 | ERROR   | [x] Expected 1 blank line after function; 0 found
 35 | ERROR   | [x] The closing brace for the class must have an empty
    |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Plugin/Mail/SMTPMailSystem.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 252 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Form/SMTPConfigForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 160 | ERROR | [x] Expected 1 space after "=>"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...0000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/smtp.module
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------
 41 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 47 | ERROR   | [x] Comments may not appear after statements
 54 | ERROR   | [x] Doc comment short description must start with a
    |         |     capital letter
 61 | ERROR   | [x] Missing function doc comment
 65 | ERROR   | [x] Missing function doc comment
 77 | ERROR   | [ ] If the line declaring an array spans longer than 80
    |         |     characters, each element should be broken into its
    |         |     own line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ewsh/pareview_temp/tests/src/Unit/Plugin/Mail/SMTPMailSystemTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  34 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 141 | ERROR   | [ ] Closing class brace must be on a line by itself
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.25 secs; Memory: 22Mb