Revision of https://git.drupal.org/project/spectra_connect.git from Fri, 03/15/2019 - 01:51

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit ab67349):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/SpectraConnectForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     45 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 796ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/SpectraConnectUtilities.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 106 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Controller/SpectraConnectController.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
  2 | ERROR | [ ] Missing short description in doc comment
 14 | ERROR | [x] Doc comment short description must end with a full stop
 19 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 21 | ERROR | [x] Missing function doc comment
 56 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/SpectraConnectForm.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   2 | ERROR   | [x] Namespaced classes, interfaces and traits should not
     |         |     begin with a file doc comment
  41 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  44 | ERROR   | [x] Short array syntax must be used to define arrays
  45 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
  46 | ERROR   | [x] Inline comments must start with a capital letter
  47 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
  49 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
 138 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/src/Form/SpectraConnectDeleteForm.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  3 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
 19 | ERROR | [x] Expected 1 space before opening brace; found 2
 25 | ERROR | [x] Short array syntax must be used to define arrays
 47 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/src/Form/SpectraConnectSettingsForm.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
 26 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/spectra_connect.install
--------------------------------------------------------------------------
FOUND 8 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | ERROR   | [ ] Missing short description in doc comment
  9 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
 13 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 25 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 28 | ERROR   | [x] Namespaced classes/interfaces/traits should be
    |         |     referenced with use statements
 30 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/spectra_connect.links.task.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.31 secs; Memory: 4Mb