Revision of https://git.drupal.org/project/splash_redirect.git 8.x-1.x from Thu, 01/10/2019 - 04:09

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 8.x-1.x branch (commit 4b92175):
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../pareview_temp/src/EventSubscriber/SplashRedirectEventSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
     22 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     33 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     34 | WARNING | Unused variable $current_uri.
     36 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     36 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...pal/pareviewsh/pareview_temp/src/Form/SplashRedirectSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
      48 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     115 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     124 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     129 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     133 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/splash_redirect.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     6 | WARNING | @author tags are not usually used in Drupal, because over
       |         | time multiple contributors will touch the code anyway
    --------------------------------------------------------------------------
    
    Time: 418ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/form.css
--------------------------------------------------------------------------
FOUND 44 ERRORS AFFECTING 36 LINES
--------------------------------------------------------------------------
  2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR | [x] Expected 1 space after colon in style definition; 0
    |       |     found
 15 | ERROR | [x] Blank lines are not allowed in class definitions
 15 | ERROR | [x] Whitespace found at end of line
 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 61 | ERROR | [x] Expected 1 space after colon in style definition; 0
    |       |     found
 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 64 | ERROR | [x] Expected 1 space after colon in style definition; 0
    |       |     found
 65 | ERROR | [x] Blank lines are not allowed in class definitions
 65 | ERROR | [x] Whitespace found at end of line
 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 68 | ERROR | [x] Expected 1 space after colon in style definition; 0
    |       |     found
 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 71 | ERROR | [ ] Style definitions must end with a semicolon
 71 | ERROR | [x] Expected 1 space after colon in style definition; 0
    |       |     found
 72 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 43 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/splash_redirect.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/splash_redirect.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/splash_redirect.services.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/src/Form/SplashRedirectSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 47 | ERROR | [x] Whitespace found at end of line
 48 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/splash_redirect.libraries.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 815ms; Memory: 4Mb