Revision of https://git.drupal.org/project/splash_redirect.git 8.x-1.x from Thu, 01/10/2019 - 22:40

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 9266a2a):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/css/form.css
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     69 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------
    
    
    FILE: .../pareview_temp/src/EventSubscriber/SplashRedirectEventSubscriber.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     56 | ERROR | Doc comment for parameter $request does not match actual
        |       | variable name 
    --------------------------------------------------------------------------
    
    Time: 1.11 secs; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../pareview_temp/src/EventSubscriber/SplashRedirectEventSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     75 | WARNING | Unused variable $current_uri.
    --------------------------------------------------------------------------
    
    
    FILE: ...pal/pareviewsh/pareview_temp/src/Form/SplashRedirectSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
      48 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     115 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     124 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     129 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     133 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/splash_redirect.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     6 | WARNING | @author tags are not usually used in Drupal, because over
       |         | time multiple contributors will touch the code anyway
    --------------------------------------------------------------------------
    
    Time: 449ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.