Revision of https://git.drupal.org/project/splash_redirect.git 8.x-1.x from Thu, 01/10/2019 - 23:52

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 0a85eec):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pal/pareviewsh/pareview_temp/src/Form/SplashRedirectSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      73 | WARNING | Node::load calls should be avoided in classes, use
         |         | dependency injection instead
     149 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     154 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     158 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 389ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: .../vendor/drupal/pareviewsh/pareview_temp/splash_redirect.services.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/splash_redirect.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 12 | ERROR | [x] Doc comment long description must end with a full stop
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 944ms; Memory: 4Mb