https://git.drupal.org/project/stripe_checkout.git 8.x-2.x

Primary tabs

Review of the 8.x-2.x branch (commit 2393bc5):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The stripe_checkout.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...iew_temp/src/Plugin/Field/FieldFormatter/StripeCheckoutFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      99 | WARNING | Only string literals should be passed to t() where
         |         | possible
     102 | WARNING | Only string literals should be passed to t() where
         |         | possible
     105 | WARNING | Only string literals should be passed to t() where
         |         | possible
    --------------------------------------------------------------------------
    
    Time: 784ms; Memory: 4Mb
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 6, col 11, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 12, col 38, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 13, col 7, Error - Split 'var' declarations into multiple statements. (one-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 13, col 30, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 13, col 46, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/checkout.js: line 21, col 59, Error - Strings must use singlequote. (quotes)
    
    6 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...iew_temp/src/Plugin/Field/FieldFormatter/StripeCheckoutFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
    --------------------------------------------------------------------------
      44 | WARNING | #description values usually have to run through t() for
         |         | translation
      51 | WARNING | #description values usually have to run through t() for
         |         | translation
      58 | WARNING | #description values usually have to run through t() for
         |         | translation
      65 | WARNING | #description values usually have to run through t() for
         |         | translation
      90 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     109 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     130 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     137 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...l/pareviewsh/pareview_temp/src/Controller/StripeChargeController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     90 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/stripe_checkout.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 377ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.