https://git.drupal.org/project/taxonomy_term_depth.git 7.x-1.x

Primary tabs

Review of the 7.x-1.x branch (commit cc4ffba):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The taxonomy_term_depth.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/constants.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     14 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.test
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     10 | WARNING | Class name must be prefixed with the project name
        |         | "TaxonomyTermDepth"
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.batch.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     68 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.install
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     25 | ERROR | Do not use t() or st() in installation phase hooks, use $t
        |       | = get_t() to retrieve the appropriate localization function
        |       | name
    --------------------------------------------------------------------------
    
    Time: 257ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/constants.inc
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  4 | ERROR | [x] Doc comment short description must end with a full stop
 12 | ERROR | [x] Doc comment short description must end with a full stop
 14 | ERROR | [x] Comments may not appear after statements
 14 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
 17 | ERROR | [x] Doc comment short description must end with a full stop
 22 | ERROR | [x] Doc comment short description must end with a full stop
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.test
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------
   3 | ERROR   | [ ] Missing short description in doc comment
  13 | ERROR   | [x] Missing function doc comment
  21 | ERROR   | [x] Visibility must be declared on method "setUp"
  21 | ERROR   | [x] Missing function doc comment
  24 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'taxonomy'
  28 | ERROR   | [x] Expected 1 blank line after function; 2 found
  43 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
  75 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
  97 | ERROR   | [x] Missing function doc comment
  97 | ERROR   | [ ] Public method name
     |         |     "DynamicDepthCalculationTest::_testDepthCache" is
     |         |     not in lowerCamel format
  99 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 114 | ERROR   | [x] Missing function doc comment
 114 | ERROR   | [ ] Public method name
     |         |     "DynamicDepthCalculationTest::_testDepthProperty" is
     |         |     not in lowerCamel format
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areview_temp/includes/taxonomy_term_depth_handler_field_taxonomy.inc
--------------------------------------------------------------------------
FOUND 17 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  7 | ERROR   | [x] There must be exactly one blank line after the file
    |         |     comment
  7 | ERROR   | [x] Additional blank lines found at end of doc comment
  8 | ERROR   | [x] Missing class doc comment
  8 | ERROR   | [ ] Class name must begin with a capital letter
  8 | ERROR   | [ ] Class name must use UpperCamel naming without
    |         |     underscores
 15 | ERROR   | [x] Visibility must be declared on method "construct"
 15 | ERROR   | [x] Expected 1 blank line before function; 0 found
 20 | ERROR   | [x] Visibility must be declared on method
    |         |     "option_definition"
 20 | ERROR   | [x] Missing function doc comment
 20 | ERROR   | [ ] Method name
    |         |     "taxonomy_term_depth_handler_field_taxonomy::option_definition"
    |         |     is not in lowerCamel format
 27 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 29 | ERROR   | [x] Visibility must be declared on method "options_form"
 29 | ERROR   | [ ] Method name
    |         |     "taxonomy_term_depth_handler_field_taxonomy::options_form"
    |         |     is not in lowerCamel format
 32 | WARNING | [ ] Avoid backslash escaping in translatable strings when
    |         |     possible, use "" quotes instead
 41 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
 45 | ERROR   | [x] Visibility must be declared on method "render_link"
 45 | ERROR   | [ ] Method name
    |         |     "taxonomy_term_depth_handler_field_taxonomy::render_link"
    |         |     is not in lowerCamel format
 78 | ERROR   | [x] Expected 1 blank line after function; 0 found
 79 | ERROR   | [x] The closing brace for the class must have an empty
    |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ew_temp/includes/taxonomy_term_depth_handler_filter_has_children.inc
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  8 | ERROR | [x] There must be exactly one blank line after the file
    |       |     comment
  9 | ERROR | [x] Missing class doc comment
  9 | ERROR | [ ] Class name must begin with a capital letter
  9 | ERROR | [ ] Class name must use UpperCamel naming without
    |       |     underscores
 11 | ERROR | [x] Visibility must be declared on method "query"
 11 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.batch.inc
--------------------------------------------------------------------------
FOUND 15 ERRORS AND 1 WARNING AFFECTING 14 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | ERROR   | [ ] Missing short description in doc comment
  7 | ERROR   | [x] Doc comment short description must end with a full
    |         |     stop
 11 | ERROR   | [x] Missing function doc comment
 23 | ERROR   | [x] Missing function doc comment
 35 | ERROR   | [x] Case breaking statements must be followed by a single
    |         |     blank line
 41 | ERROR   | [x] Missing function doc comment
 43 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 51 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 53 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 56 | ERROR   | [x] Closing parenthesis of array declaration must be on a
    |         |     new line
 68 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
 68 | ERROR   | [x] No space found before comment text; expected "//
    |         |     $sandbox['position'] += $sandbox['bunch'];" but found
    |         |     "//$sandbox['position'] += $sandbox['bunch'];"
 68 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 74 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 79 | ERROR   | [x] Expected 1 space before ":"; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.module
--------------------------------------------------------------------------
FOUND 64 ERRORS AND 6 WARNINGS AFFECTING 51 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   8 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  29 | ERROR   | [ ] Missing short description in doc comment
  31 | ERROR   | [ ] Missing parameter comment
  31 | ERROR   | [ ] Missing parameter type
  32 | ERROR   | [ ] Missing parameter comment
  33 | ERROR   | [ ] Description for the @return value is missing
  40 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  42 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  45 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  61 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  61 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  64 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  71 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  78 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  79 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
  79 | ERROR   | [ ] Missing parameter comment
  79 | ERROR   | [ ] Missing parameter type
  80 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
  80 | ERROR   | [ ] Description for the @return value is missing
  93 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  94 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
  94 | ERROR   | [ ] Missing parameter type
  95 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 108 | ERROR   | [x] Expected 1 blank line after function; 2 found
 112 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 113 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 113 | ERROR   | [ ] Missing parameter type
 114 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 129 | ERROR   | [ ] Missing short description in doc comment
 130 | ERROR   | [ ] Missing parameter comment
 130 | ERROR   | [ ] Missing parameter type
 131 | ERROR   | [ ] Description for the @return value is missing
 136 | ERROR   | [x] Expected 1 blank line after function; 2 found
 141 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 141 | ERROR   | [ ] Missing parameter comment
 141 | ERROR   | [ ] Missing parameter type
 142 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 142 | ERROR   | [ ] Description for the @return value is missing
 157 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 157 | ERROR   | [ ] Missing parameter comment
 157 | ERROR   | [ ] Missing parameter type
 158 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 158 | ERROR   | [ ] Description for the @return value is missing
 163 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 173 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 174 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 174 | ERROR   | [ ] Missing parameter comment
 174 | ERROR   | [ ] Missing parameter type
 175 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 175 | ERROR   | [ ] Description for the @return value is missing
 180 | ERROR   | [x] There should be no white space after an opening "["
 180 | ERROR   | [x] There should be no white space before a closing "]"
 186 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
 207 | ERROR   | [x] Array indentation error, expected 4 spaces but found
     |         |     6
 208 | ERROR   | [x] Array closing indentation error, expected 2 spaces
     |         |     but found 4
 212 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
     |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
     |         |     "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
     |         |     Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
 213 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 213 | ERROR   | [ ] Doc comment short description must be on a single
     |         |     line, further text should be a separate paragraph
 216 | ERROR   | [x] Whitespace found at end of line
 217 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 222 | ERROR   | [x] Whitespace found at end of line
 223 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 228 | ERROR   | [x] Whitespace found at end of line
 229 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 233 | ERROR   | [x] Whitespace found at end of line
 234 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 238 | ERROR   | [x] Whitespace found at end of line
 242 | WARNING | [ ] Avoid backslash escaping in translatable strings
     |         |     when possible, use "" quotes instead
 251 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found:
     |         |     'taxonomy_term_depth_handler_filter_has_children'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 41 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/taxonomy_term_depth.install
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | ERROR   | [ ] Missing short description in doc comment
  7 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 19 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 31 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
 47 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 492ms; Memory: 4Mb