https://git.drupal.org/project/twig_tweak.git 8.x-2.x

Primary tabs

Review of the 8.x-2.x branch (commit 5372b82):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The twig_tweak_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/TwigExtension.php
    --------------------------------------------------------------------------
    FOUND 12 ERRORS AFFECTING 12 LINES
    --------------------------------------------------------------------------
      106 | ERROR | Tags must be grouped together in a doc comment
      115 | ERROR | Tags must be grouped together in a doc comment
      975 | ERROR | Tags must be grouped together in a doc comment
      980 | ERROR | Tags must be grouped together in a doc comment
     1044 | ERROR | Tags must be grouped together in a doc comment
     1047 | ERROR | Tags must be grouped together in a doc comment
     1050 | ERROR | Tags must be grouped together in a doc comment
     1052 | ERROR | Tags must be grouped together in a doc comment
     1110 | ERROR | Tags must be grouped together in a doc comment
     1112 | ERROR | Tags must be grouped together in a doc comment
     1118 | ERROR | Tags must be grouped together in a doc comment
     1120 | ERROR | Tags must be grouped together in a doc comment
    --------------------------------------------------------------------------
    
    Time: 2.36 secs; Memory: 10Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/TwigExtension.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 33 WARNINGS AFFECTING 33 LINES
    --------------------------------------------------------------------------
      134 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      139 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      140 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      143 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      149 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      150 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      151 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      205 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      208 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      220 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      222 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      272 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      275 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      313 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      323 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      356 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      357 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      359 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      389 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      433 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      485 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      548 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      568 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      608 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      609 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      610 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      643 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      707 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      708 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      740 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      786 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
      872 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
     1000 | WARNING | \Drupal calls should be avoided in classes, use
          |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 1.28 secs; Memory: 8Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.