https://git.drupal.org/project/videobackground.git

Primary tabs

Review of the 8.x-1.x branch (commit 64b01b9):
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./videobackground.css:                         ASCII text, with no line terminators
    
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/videobackground.css
    --------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | ERROR | [x] Expected 1 space before opening brace of class
       |       |     definition; 0 found
     1 | ERROR | [x] Opening brace should be the last content on the line
     1 | ERROR | [x] Expected 1 newline at end of file; 0 found
     1 | ERROR | [x] Closing brace of class definition must be on new line
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.05 secs; Memory: 6Mb
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/videobackground.js: line 34, col 36, Error - Trailing spaces not allowed. (no-trailing-spaces)
    
    1 problem
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.