https://git.drupal.org/project/view_custom_table.git

Primary tabs

Git errors: Review of the 7.x-1.x branch (commit f317d2f):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...review_temp/views/handlers/view_custom_table_handler_filter_date.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
    --------------------------------------------------------------------------
     37 | WARNING | #options values usually have to run through t() for
        |         | translation
     37 | WARNING | #options values usually have to run through t() for
        |         | translation
    --------------------------------------------------------------------------
    
    Time: 1.24 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ew_temp/views/handlers/view_custom_table_handler_field_date_time.inc
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 13 | ERROR | Class name must begin with a capital letter
 13 | ERROR | Class name must use UpperCamel naming without underscores
 18 | ERROR | Public method name
    |       | "view_custom_table_handler_field_date_time::option_definition"
    |       | is not in lowerCamel format
 33 | ERROR | Public method name
    |       | "view_custom_table_handler_field_date_time::options_form"
    |       | is not in lowerCamel format
--------------------------------------------------------------------------


FILE: ...review_temp/views/handlers/view_custom_table_handler_filter_date.inc
--------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------
  13 | ERROR | Class name must begin with a capital letter
  13 | ERROR | Class name must use UpperCamel naming without underscores
  18 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::option_definition"
     |       | is not in lowerCamel format
  30 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::value_form" is not
     |       | in lowerCamel format
  48 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::options_validate"
     |       | is not in lowerCamel format
  62 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::exposed_validate"
     |       | is not in lowerCamel format
  87 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::validate_valid_time"
     |       | is not in lowerCamel format
 111 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::build_group_validate"
     |       | is not in lowerCamel format
 138 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::accept_exposed_input"
     |       | is not in lowerCamel format
 175 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::op_between" is not
     |       | in lowerCamel format
 192 | ERROR | Public method name
     |       | "view_custom_table_handler_filter_date::op_simple" is not
     |       | in lowerCamel format
--------------------------------------------------------------------------


FILE: ...pareview_temp/views/handlers/view_custom_table_handler_sort_date.inc
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 16 | ERROR | Class name must begin with a capital letter
 16 | ERROR | Class name must use UpperCamel naming without underscores
 21 | ERROR | Public method name
    |       | "view_custom_table_handler_sort_date::option_definition" is
    |       | not in lowerCamel format
 32 | ERROR | Public method name
    |       | "view_custom_table_handler_sort_date::options_form" is not
    |       | in lowerCamel format
--------------------------------------------------------------------------

Time: 2.02 secs; Memory: 6Mb