Revision of https://git.drupal.org/project/viewportchecker 8.x-1.x from Sun, 11/03/2019 - 19:29

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit f438404):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/SettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     40 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
     41 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 355ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Commands/Drush9Commands.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
 63 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 65 | ERROR   | [ ] Public method name
    |         |     "Drush9Commands::drush_download_file" is not in
    |         |     lowerCamel format
 79 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: $url
 94 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: $url
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/SettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 52 | ERROR | [x] No space found before comment text; expected "//
    |       |     parent::validateForm($form, $form_state);" but found
    |       |     "//parent::validateForm($form, $form_state);"
 52 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/viewportchecker.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 11 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
 12 | ERROR | [x] Blank comments are not allowed
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 770ms; Memory: 4Mb