https://git.drupal.org/project/views_autosubmit.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit c1946c1):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 6, col 2, Error - Use the function form of 'use strict'. (strict)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 8, col 1, Error - Expected indentation of 2 spaces but found 0. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 9, col 19, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 11, col 27, Error - Unexpected space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 44, col 8, Error - Expected indentation of 6 spaces but found 7. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 56, col 15, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 59, col 26, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/views_autosubmit.js: line 66, col 2, Error - Missing semicolon. (semi)
    
    8 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areviewsh/pareview_temp/src/Plugin/views/exposed_form/Autosubmit.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     5 | WARNING | @author tags are not usually used in Drupal, because over
       |         | time multiple contributors will touch the code anyway
    --------------------------------------------------------------------------
    
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/views_autosubmit.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 191ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...areviewsh/pareview_temp/src/Plugin/views/exposed_form/Autosubmit.php
--------------------------------------------------------------------------
FOUND 11 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
  3 | ERROR   | [x] Namespaced classes, interfaces and traits should not
    |         |     begin with a file doc comment
  3 | ERROR   | [ ] Missing short description in doc comment
 13 | WARNING | [x] Unused use statement
 28 | ERROR   | [ ] Doc comment short description must start with a
    |         |     capital letter
 30 | ERROR   | [x] Expected 1 blank line before function; 0 found
 33 | WARNING | [ ] Code after RETURN statement cannot be executed
 33 | ERROR   | [x] Short array syntax must be used to define arrays
 35 | WARNING | [ ] Code after RETURN statement cannot be executed
 39 | ERROR   | [ ] Doc comment short description must start with a
    |         |     capital letter
 44 | ERROR   | [x] Short array syntax must be used to define arrays
 53 | ERROR   | [ ] Doc comment short description must start with a
    |         |     capital letter
 57 | ERROR   | [x] Short array syntax must be used to define arrays
 57 | ERROR   | [x] Short array syntax must be used to define arrays
 57 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/views_autosubmit.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 362ms; Memory: 4Mb