https://git.drupal.org/project/views_ifempty.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 265baf5):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/views_ifempty.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 294ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/views_ifempty.views.inc
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 13 | ERROR | [x] Short array syntax must be used to define arrays
 14 | ERROR | [x] Short array syntax must be used to define arrays
 17 | ERROR | [x] Short array syntax must be used to define arrays
 20 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/src/Plugin/views/field/ViewsIfEmpty.php
--------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------
   3 | ERROR | [x] Namespaced classes, interfaces and traits should not
     |       |     begin with a file doc comment
  50 | ERROR | [x] Short array syntax must be used to define arrays
  51 | ERROR | [x] Short array syntax must be used to define arrays
  52 | ERROR | [x] Short array syntax must be used to define arrays
  64 | ERROR | [x] Short array syntax must be used to define arrays
  75 | ERROR | [x] Short array syntax must be used to define arrays
  83 | ERROR | [x] Short array syntax must be used to define arrays
  91 | ERROR | [x] Short array syntax must be used to define arrays
 103 | ERROR | [x] Short array syntax must be used to define arrays
 106 | ERROR | [x] Short array syntax must be used to define arrays
 109 | ERROR | [x] Short array syntax must be used to define arrays
 109 | ERROR | [x] Short array syntax must be used to define arrays
 119 | ERROR | [x] Short array syntax must be used to define arrays
 167 | ERROR | [x] Expected 1 blank line after function; 0 found
 168 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 559ms; Memory: 4Mb