https://git.drupal.org/project/webform_donate.git

Primary tabs

Review of the 8.x-3.x branch (commit c9039bd):
  • There should be only one README file, either README.md or README.txt.
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/webform_donate.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...pareviewsh/pareview_temp/src/Plugin/WebformElement/WebformDonate.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      42 | WARNING | There must be no blank line following an inline comment
     309 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Element/WebformDonate.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      56 | WARNING | Unused variable $webform.
     175 | WARNING | Unused variable $default_key.
    --------------------------------------------------------------------------
    
    Time: 1.04 secs; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...pareviewsh/pareview_temp/src/Plugin/WebformElement/WebformDonate.php
--------------------------------------------------------------------------
FOUND 33 ERRORS AND 7 WARNINGS AFFECTING 34 LINES
--------------------------------------------------------------------------
  42 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  42 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
  42 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  63 | ERROR   | [ ] Missing short description in doc comment
  64 | ERROR   | [ ] Description for the @return value is missing
  82 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  98 | ERROR   | [ ] Missing short description in doc comment
  99 | ERROR   | [ ] Description for the @return value is missing
 112 | ERROR   | [ ] Missing short description in doc comment
 113 | ERROR   | [ ] Missing parameter comment
 114 | ERROR   | [ ] Missing parameter comment
 116 | ERROR   | [ ] Description for the @return value is missing
 142 | ERROR   | [x] Short array syntax must be used to define arrays
 165 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 184 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 186 | ERROR   | [x] Line indented incorrectly; expected 11 spaces, found
     |         |     10
 290 | ERROR   | [x] Inline comments must start with a capital letter
 291 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 292 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 293 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 294 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 295 | WARNING | [ ] Line exceeds 80 characters; contains 145 characters
 295 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 297 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 298 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 299 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 299 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     14
 300 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 301 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 302 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     14
 303 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     14
 304 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 306 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 307 | WARNING | [ ] Line exceeds 80 characters; contains 224 characters
 307 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     12
 308 | ERROR   | [x] Line indented incorrectly; expected 5 spaces, found
     |         |     6
 309 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 309 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 312 | ERROR   | [x] Expected 1 blank line after function; 2 found
 315 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ewsh/pareview_temp/src/Plugin/WebformHandler/DonateSubmitHandler.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  51 | ERROR | [x] Short array syntax must be used to define arrays
 136 | ERROR | [x] Use "elseif" in place of "else if"
 136 | ERROR | [x] A cast statement must be followed by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Element/WebformDonate.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
   9 | WARNING | [x] Unused use statement
  24 | WARNING | [ ] Possible useless method overriding detected
  87 | ERROR   | [x] Short array syntax must be used to define arrays
  88 | ERROR   | [x] Short array syntax must be used to define arrays
  89 | ERROR   | [x] Short array syntax must be used to define arrays
 141 | ERROR   | [x] Short array syntax must be used to define arrays
 142 | ERROR   | [x] Short array syntax must be used to define arrays
 143 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.65 secs; Memory: 6Mb