https://git.drupal.org/project/yasm.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit cb8f378):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Groups.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     307 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 3.41 secs; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...temp/modules/yasm_charts/src/Services/YasmChartsBuilderInterface.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 21 | ERROR | Type hint "array" missing for $build
 21 | ERROR | Type hint "array" missing for $settings
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Files.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 120 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Groups.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 123 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
 124 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
--------------------------------------------------------------------------

Time: 5.47 secs; Memory: 8Mb