https://git.drupal.org/project/yasm.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 0475dae):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Groups.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     209 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 2.32 secs; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/Controller/Dashboard.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
  78 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  81 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  84 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  90 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  93 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  96 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
  99 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
 102 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
 105 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Files.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 103 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Controller/Groups.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 140 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
 141 | WARNING | Do not concatenate strings to translatable strings, they
     |         | should be part of the t() argument and you should use
     |         | placeholders
--------------------------------------------------------------------------

Time: 3.28 secs; Memory: 6Mb