https://git.drupal.org/project/youtube.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit a336716):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
  • The youtube.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/youtube.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | WARNING | Remove "version" from the info file, it will be added by
       |         | drupal.org packaging automatically
    --------------------------------------------------------------------------
    
    Time: 2.82 secs; Memory: 8Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/youtube.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    --------------------------------------------------------------------------
     251 | WARNING | Variable $remote_uri is undefined.
     549 | WARNING | Unused global variable $base_url.
     550 | WARNING | Unused global variable $base_path.
     552 | WARNING | Unused variable $url_options.
     556 | WARNING | Unused variable $langcode.
     562 | WARNING | Unused variable $sanitize.
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/YoutubeSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     114 | WARNING | Unused variable $fom.
    --------------------------------------------------------------------------
    
    
    FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/youtube.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      8 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
      9 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
     10 | WARNING | All dependencies must be prefixed with the project name,
        |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 1.79 secs; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.