https://git.drupal.org/sandbox/Hardik_Patel_12-3105971

Primary tabs

Git errors: Review of the @branch branch (commit d8142cb):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The workspace_access_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...or/drupal/pareviewsh/pareview_temp/src/WorkspacesServiceProvider.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     37 | WARNING | Unused variable $id.
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/EntityTypeInfo.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     89 | WARNING | Unused variable $entity_type_id.
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/WorkspaceManager.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     268 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/EntityQuery/Tables.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     66 | WARNING | Unused variable $active_workspace_id.
    --------------------------------------------------------------------------
    
    Time: 11.31 secs; Memory: 12Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/workspaces.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/WorkspacePublisher.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 54 | ERROR | Parameter $source is not described in comment
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/WorkspaceListBuilder.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  45 | ERROR | Parameter $workspace_repository is not described in
     |       | comment
 301 | ERROR | If the line declaring an array spans longer than 80
     |       | characters, each element should be broken into its own
     |       | line
 318 | ERROR | If the line declaring an array spans longer than 80
     |       | characters, each element should be broken into its own
     |       | line
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/ViewsQueryAlter.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 351 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 382 | ERROR   | [x] Separate the @return and @throws sections by a blank
     |         |     line.
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/EntityTypeInfo.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 106 | ERROR | Type hint "array" missing for $definitions
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/src/EntityQuery/Tables.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 127 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/src/WorkspaceAssociation.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 136 | ERROR | If the line declaring an array spans longer than 80
     |       | characters, each element should be broken into its own
     |       | line
--------------------------------------------------------------------------


FILE: ...onstraint/EntityReferenceSupportedNewEntitiesConstraintValidator.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 32 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------


FILE: ...wsh/pareview_temp/src/EventSubscriber/WorkspaceRequestSubscriber.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 96 | ERROR | [ ] Doc comment short description must start with a capital
    |       |     letter
 96 | ERROR | [x] Doc comment short description must end with a full stop
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/src/EntityAccess.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
 62 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 64 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 66 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 69 | WARNING | Hook implementations should not duplicate @return
    |         | documentation
 88 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 90 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 92 | WARNING | Hook implementations should not duplicate @param
    |         | documentation
 95 | WARNING | Hook implementations should not duplicate @return
    |         | documentation
--------------------------------------------------------------------------


FILE: ...p/tests/modules/workspace_update_test/workspace_update_test.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...p/tests/modules/workspace_access_test/workspace_access_test.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/tests/src/Functional/PathWorkspacesTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 22 | ERROR | If the line declaring an array spans longer than 80
    |       | characters, each element should be broken into its own line
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/tests/src/Functional/Update/WorkspacesUpdateTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 97 | ERROR | If the line declaring an array spans longer than 80
    |       | characters, each element should be broken into its own line
--------------------------------------------------------------------------


FILE: ...mp/tests/src/Functional/EntityResource/WorkspaceResourceTestBase.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 4 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------
  51 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  54 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
  57 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 182 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 183 | WARNING | [ ] Code after RETURN statement cannot be executed
 185 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 186 | WARNING | [ ] Code after RETURN statement cannot be executed
 188 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 189 | WARNING | [ ] Code after RETURN statement cannot be executed
 191 | ERROR   | [x] Case breaking statements must be followed by a
     |         |     single blank line
 192 | WARNING | [ ] Code after RETURN statement cannot be executed
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ewsh/pareview_temp/tests/src/Unit/WorkspaceRequestSubscriberTest.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 22 | ERROR | Missing short description in doc comment
 27 | ERROR | Missing short description in doc comment
 32 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/tests/src/Unit/ActiveWorkspaceCheckTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 45 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/tests/src/Kernel/WorkspaceCRUDTest.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
 250 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 258 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
 267 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
 279 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
 290 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
 306 | ERROR | [ ] If the line declaring an array spans longer than 80
     |       |     characters, each element should be broken into its own
     |       |     line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...reviewsh/pareview_temp/tests/src/Kernel/WorkspaceIntegrationTest.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
  87 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 104 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 105 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 246 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 246 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 281 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 281 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 330 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 336 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 400 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own
     |         | line
 580 | WARNING | Line exceeds 80 characters; contains 84 characters
 582 | WARNING | Line exceeds 80 characters; contains 94 characters
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/tests/src/Kernel/WorkspaceTestTrait.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 74 | ERROR | [x] Doc comment short description must end with a full stop
 74 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/workspaces.post_update.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 79 | ERROR | If the line declaring an array spans longer than 80
    |       | characters, each element should be broken into its own line
 89 | ERROR | If the line declaring an array spans longer than 80
    |       | characters, each element should be broken into its own line
--------------------------------------------------------------------------

Time: 14.46 secs; Memory: 18Mb