https://git.drupal.org/sandbox/michael_dajewski/2896782.git

Primary tabs

Review of the 7.x-1.x branch (commit 2ef371b):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../plugins/views_inject_view_results_views_plugin_display_extender.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     35 | WARNING | Do not use the raw $form_state['input'], use
        |         | $form_state['values'] instead where possible
     35 | WARNING | Do not use the raw $form_state['input'], use
        |         | $form_state['values'] instead where possible
     85 | WARNING | Do not use the raw $form_state['input'], use
        |         | $form_state['values'] instead where possible
     85 | WARNING | Do not use the raw $form_state['input'], use
        |         | $form_state['values'] instead where possible
    --------------------------------------------------------------------------
    
    Time: 812ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: .../drupal/pareviewsh/pareview_temp/views_inject_view_results.views.inc
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 36 | ERROR | Missing parameter type
 38 | ERROR | Missing parameter type
 56 | ERROR | Missing parameter type
--------------------------------------------------------------------------


FILE: .../plugins/views_inject_view_results_views_plugin_display_extender.inc
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  21 | ERROR | [x] Visibility must be declared on method
     |       |     "options_definition_alter"
  21 | ERROR | [ ] Method name
     |       |     "ViewsInjectViewResultsViewsPluginDisplayExtender::options_definition_alter"
     |       |     is not in lowerCamel format
  30 | ERROR | [x] Visibility must be declared on method "options_form"
  30 | ERROR | [ ] Method name
     |       |     "ViewsInjectViewResultsViewsPluginDisplayExtender::options_form"
     |       |     is not in lowerCamel format
 107 | ERROR | [x] Visibility must be declared on method "options_submit"
 107 | ERROR | [ ] Method name
     |       |     "ViewsInjectViewResultsViewsPluginDisplayExtender::options_submit"
     |       |     is not in lowerCamel format
 125 | ERROR | [x] Visibility must be declared on method
     |       |     "options_summary"
 125 | ERROR | [ ] Method name
     |       |     "ViewsInjectViewResultsViewsPluginDisplayExtender::options_summary"
     |       |     is not in lowerCamel format
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ..._temp/views/plugins/views_inject_view_results_views_plugin_style.inc
--------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 25 | ERROR | [ ] Class property $row_tokens should use lowerCamel naming
    |       |     without underscores
 25 | ERROR | [x] The var keyword must not be used to declare a property
 25 | ERROR | [ ] Visibility must be declared on property "$row_tokens"
 32 | ERROR | [ ] Class property $row_plugin should use lowerCamel naming
    |       |     without underscores
 32 | ERROR | [x] The var keyword must not be used to declare a property
 32 | ERROR | [ ] Visibility must be declared on property "$row_plugin"
 48 | ERROR | [x] Visibility must be declared on method
    |       |     "render_grouping_sets"
 48 | ERROR | [ ] Type hint "array" missing for $sets
 48 | ERROR | [ ] Method name
    |       |     "ViewsInjectViewResultsViewsPluginStyle::render_grouping_sets"
    |       |     is not in lowerCamel format
 85 | ERROR | [x] Visibility must be declared on method "render_fields"
 85 | ERROR | [ ] Type hint "array" missing for $result
 85 | ERROR | [ ] Method name
    |       |     "ViewsInjectViewResultsViewsPluginStyle::render_fields"
    |       |     is not in lowerCamel format
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.12 secs; Memory: 4Mb