https://git.drupal.org/sandbox/veegishx-3036517

Primary tabs

Review of the 8.x-2.x branch (commit 876cdec):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eviewsh/pareview_temp/src/Plugin/Field/FieldWidget/Http451Widget.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     30 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...ewsh/pareview_temp/src/EventSubscriber/Http451RedirectSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
      34 | WARNING | Unused private method getIpAddress()
      42 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      55 | WARNING | Unused private method getIpAddressOriginCountry()
      57 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      86 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     103 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     110 | WARNING | Unused variable $worldwide.
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/Form/Http451Form.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     36 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     72 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     74 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 527ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 278 characters
  8 | WARNING | Line exceeds 80 characters; contains 112 characters
 10 | WARNING | Line exceeds 80 characters; contains 222 characters
 12 | WARNING | Line exceeds 80 characters; contains 149 characters
 14 | WARNING | Line exceeds 80 characters; contains 143 characters
 16 | WARNING | Line exceeds 80 characters; contains 158 characters
 19 | WARNING | Line exceeds 80 characters; contains 236 characters
 23 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: .../drupal/pareviewsh/pareview_temp/config/install/http451.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/config/schema/http451.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 29 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...eviewsh/pareview_temp/src/Plugin/Field/FieldWidget/Http451Widget.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
 29 | WARNING | Line exceeds 80 characters; contains 95 characters
 48 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
 55 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
 62 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
 70 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
--------------------------------------------------------------------------


FILE: ...ewsh/pareview_temp/src/EventSubscriber/Http451RedirectSubscriber.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  82 | WARNING | Line exceeds 80 characters; contains 83 characters
 107 | WARNING | Line exceeds 80 characters; contains 88 characters
 133 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/Form/Http451Form.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 62 | WARNING | Empty return statement not required here
--------------------------------------------------------------------------


FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/CHANGELOG.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  4 | WARNING | Line exceeds 80 characters; contains 84 characters
 20 | WARNING | Line exceeds 80 characters; contains 116 characters
 22 | WARNING | Line exceeds 80 characters; contains 104 characters
 65 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/http451.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 921ms; Memory: 4Mb